Skip to content

fix: improve transaction cost estimation for pay modal #5548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: improve transaction cost estimation for pay modal #5548

merged 1 commit into from
Dec 2, 2024

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 2, 2024 •
edited
Loading

Problem solved

fixes CNCT-2514

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: e7dd37f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 1:26am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 1:26am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 1:26am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 1:26am

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 2, 2024
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Dec 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@linear
Copy link

linear bot commented Dec 2, 2024

CNCT-2514 Pay tx modal shows insufficient funds warning even if the account has enough

@joaquim-verges joaquim-verges marked this pull request as ready for review December 2, 2024 01:15
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.92 KB (0%) 959 ms (0%) 554 ms (+3.51% 🔺) 1.6 s
thirdweb (cjs) 107.32 KB (+0.06% 🔺) 2.2 s (+0.06% 🔺) 930 ms (+8.37% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 108 ms (+66.18% 🔺) 220 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 7 ms (-54.52% 🔽) 17 ms
thirdweb/react (minimal + tree-shaking) 18.28 KB (0%) 366 ms (0%) 155 ms (+161.86% 🔺) 520 ms

@codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 14.81481% with 23 lines in your changes missing coverage. Please review.

Project coverage is 46.18%. Comparing base (8aa454c) to head (e7dd37f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/transaction/utils.ts 8.33% 22 Missing ⚠️
...react/core/hooks/transaction/useSendTransaction.ts 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5548      +/-   ##
==========================================
- Coverage   46.19%   46.18%   -0.01%     
==========================================
  Files        1081     1082       +1     
  Lines       58613    58626      +13     
  Branches     3933     3933              
==========================================
+ Hits        27075    27079       +4     
- Misses      30855    30864       +9     
  Partials      683      683
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 8aa454c
packages 41.74% <14.81%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...i/ConnectWallet/screens/Buy/main/useBuyTxStates.ts 9.40% <100.00%> (+0.64%) ⬆️
...react/core/hooks/transaction/useSendTransaction.ts 12.82% <50.00%> (+1.63%) ⬆️
packages/thirdweb/src/transaction/utils.ts 29.03% <8.33%> (-70.97%) ⬇️

... and 1 file with indirect coverage changes

@joaquim-verges joaquim-verges merged commit 9337925 into main Dec 2, 2024
32 of 34 checks passed
@joaquim-verges joaquim-verges deleted the fix_improve_transaction_cost_estimation_for_pay_modal branch December 2, 2024 01:30
@jnsdls jnsdls mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregfromstl gregfromstl Awaiting requested review from gregfromstl

@MananTank MananTank Awaiting requested review from MananTank

@jnsdls jnsdls Awaiting requested review from jnsdls

@edwardysun edwardysun Awaiting requested review from edwardysun

Assignees

No one assigned

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges